Compiler: remove many calls to ast.idx2name#501
Open
chqrlie wants to merge 1 commit intoc2lang:masterfrom
Open
Compiler: remove many calls to ast.idx2name#501chqrlie wants to merge 1 commit intoc2lang:masterfrom
chqrlie wants to merge 1 commit intoc2lang:masterfrom
Conversation
Member
|
This pattern now happens quite a lot: |
Contributor
Author
|
I came to the very same conclusion this morning... and
Never mind, I shall add and use new wrappers |
chqrlie
force-pushed
the
idx2name
branch
4 times, most recently
from
914bba0 to
58726eb
Compare
* add `idx2name` converter in `unused_checker.Checker` * add `Generator.emitName()` in c2i_generator and c_generator * add `Analyser.getName()`, `Analyser.getFullName()` * add `Checker.getName()`, `Checker.getFullName()` * add `Scope.getName()`, `Scope.getFullName()` * remove most calls to `Decl.getName()` and `Decl.getFullName()` in analyser * remove most calls to `Decl.getName()` in generators * remove unused functions * use name indexes in deps_generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idx2nameconverter inunused_checker.CheckerGenerator.emitNamein c2i_generator and c_generatorDecl.getNamein generators