docs(dart): align morph_core and morph_storage package metadata (#33)#34
Conversation
Refresh README and pubspec descriptions with shipped parity (runtime, OAuth helpers, host pipeline, plugins). Correct morph_storage scope: in-memory for VM/tests, not browser-storage parity. Co-authored-by: Cursor <cursoragent@cursor.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Dart morph_core documentation and package descriptions to reflect newly shipped runtime, pipeline, plugin, and OAuth parity with the TypeScript core, and clarifies morph_storage’s purpose as an in-memory storage provider for tests/VM versus browser/Flutter usage. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and package descriptions for morph_core and morph_storage to reflect the implementation of core features such as MorphClient, MorphRuntime, and the plugin system. Feedback was provided to correct an inaccuracy in the README regarding the status of MorphOptions, which is already implemented as a typed DTO.
| Typed **`MorphConfig` / strong `MorphOptions`** DTOs (vs `Map<String,dynamic>`) remain | ||
| **backlog**; config is validated as decoded JSON maps for now ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)). |
There was a problem hiding this comment.
The README states that MorphOptions DTOs remain in the backlog and compares them to Map<String, dynamic>. However, the current implementation already uses a typed MorphOptions class in the MorphClient.init signature (as seen in packages/dart/morph_core/lib/src/morph_client.dart). This part of the documentation should be updated to reflect that MorphOptions is already implemented as a strong DTO.
| Typed **`MorphConfig` / strong `MorphOptions`** DTOs (vs `Map<String,dynamic>`) remain | |
| **backlog**; config is validated as decoded JSON maps for now ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)). | |
| Typed **`MorphConfig`** DTOs (vs `Map<String,dynamic>`) remain | |
| **backlog**; config is validated as decoded JSON maps for now ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)). |
Summary
Refresh
packages/dart/morph_core/README.mdandpubspec.yamldescriptions to reflect shipped parity perdocs/dart-parity.md(MorphClient, MorphRuntime, host pipeline, plugins, OAuth helpers).Correct
morph_storagepubspec description: in-memory storage for tests/VM; browser storage remains (TS); Flutter apps use morph-data-store via morph_core_storage.Closes #33
Made with Cursor
Summary by Sourcery
Align Dart morph_core and morph_storage package metadata and documentation with the current TypeScript parity and storage architecture.
Enhancements:
Documentation: