Merged
Conversation
cel-java doesn't currently have the optimization from cel-go which optimizes calls to the 'matches' function to compile a regular expression once instead of at every invocation. Override cel-java's builtin matches functions to add a pattern compilation cache (scoped to a Validator).
pkwarren
commented
Apr 24, 2026
|
|
||
| private static final CelOptions CEL_OPTIONS = CelOptions.DEFAULT; | ||
|
|
||
| private final ConcurrentMap<String, Pattern> patternCache = new ConcurrentHashMap<>(); |
Member
Author
There was a problem hiding this comment.
Unlike the proposed fix in google/cel-java#1038, this cache is scoped to a Validator and not global.
pkwarren
commented
Apr 24, 2026
| } | ||
|
|
||
| @Benchmark | ||
| public void validateRegexPattern(Blackhole bh) throws ValidationException { |
Member
Author
There was a problem hiding this comment.
Results:
benchmark metric before after delta
validateRegexPattern time 1873.21 ns/op 1323.61 ns/op -29.3%
validateRegexPattern alloc 7828 B/op 4272 B/op -45.4%
stolas-dev
approved these changes
Apr 24, 2026
rodaine
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cel-java doesn't currently have the optimization from cel-go which optimizes calls to the 'matches' function to compile a regular expression once instead of at every invocation.
Override cel-java's builtin matches functions to add a pattern compilation cache (scoped to a Validator).