Enhance isEmail validation#250
Merged
smaye81 merged 3 commits intosayers/validation_upgradesfrom Mar 28, 2025
Merged
Conversation
added 2 commits
March 27, 2025 15:35
smaye81
requested review from
pkwarren and
timostamm
and removed request for
timostamm
pkwarren
reviewed
Mar 28, 2025
| import com.google.common.primitives.Bytes; | ||
| import inet.ipaddr.IPAddress; | ||
| import inet.ipaddr.IPAddressString; | ||
| import jakarta.mail.internet.AddressException; |
Member
There was a problem hiding this comment.
Are we now able to remove this dependency as well?
pkwarren
approved these changes
Mar 28, 2025
timostamm
reviewed
Mar 28, 2025
timostamm
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhances the current isEmail validation by using a consistent regex that will be used across protovalidate implementations.