BTI-841: Full test suite with 100% coverage and SDK correctness fixes#4
Merged
Conversation
raise BuckarooApiError on non-2xx + malformed JSON; restore single exception hierarchy. expand observer masking set with cvc/bic/pan/ expirydate/encryptedcarddata. cover BuckarooHttpClient, BuckarooResponse, BuckarooLoggingObserver, ContextualLoggingObserver, factories at 100%.
Fix misnamed tests, remove duplicates, add missing assertions, merge KlarnaKP dead code, mark known bugs as xfail, fix Klarna copy-paste, add refund/cancel/403 coverage, fix style inconsistencies. 1744 passed, 0 skipped, 0 failures, 100% coverage.
- Lowercase externalPayment registry key so create_builder() finds it - Handle timeout=None in requests strategy error message - Mask Values paired with sensitive Names in Buckaroo Parameters lists
…refunds and fast checkouts
…ons for payment methods
…or improved clarity and consistency
vildanbina
changed the title
ShuCh3n
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpersclass (renamed fromTestHelpersto dodge pytest collection),standard_payload,populate_required_fields, and assertion helpers verifying wire-levelActionviaRecordingMock.cancel()now sendsAction=Cancel(was silentlyPay);ParameterValidationErrorgrammar fixed;IdealQrBuilder+BuckarooErrorforward-refs resolved; refund/cancelAuthorize drop unreachableAmountDebit-guard branches.BuckarooLoggingObservermasks theValuesibling of any sensitive parameterName(cvc, bic, pan, iban, encryptedcarddata, etc.).BuckarooStatusCodeenum exported frombuckaroo.models;confirm_credential()onBuckarooClient;cancelAuthorize,authorizeWithToken,payWithTokencapability methods;externalpaymentregistry key lowercased.http.client.post()raisesBuckarooApiErroron any non-2xx;refund()readsoriginal_transaction_key(snake_case) from payload, not camelCase;get_redirect_url()prefersrequired_action.redirect_urloverself.redirect_url.concurrencygroup prevents duplicate PR runs;python_requires >= 3.9; CHANGELOG added; LF enforced via.gitattributes.