Skip to content

feat(ui): added search input and checkbox for submit pr page#146

Merged
abhijeetw035 merged 2 commits intobsoc-bitbyte:mainfrom
AtharvPS13:searchinput
Jul 16, 2025
Merged

feat(ui): added search input and checkbox for submit pr page#146
abhijeetw035 merged 2 commits intobsoc-bitbyte:mainfrom
AtharvPS13:searchinput

Conversation

@AtharvPS13
Copy link
Copy Markdown
Contributor

@AtharvPS13 AtharvPS13 commented Jul 13, 2025

📌 What does this PR do?

This PR adds search input on submit PR page ,which helps to filter pr based on search query.
This PR also adds checkbox to filter PRs bases on difficulties

✅ Summary of Changes

  • Feature added / Bug fixed
  • Code refactored / cleaned up
  • UI updated (if applicable)
  • Tests written or updated

📷 Screenshots / Demo (if applicable)

BitByte.Summer.of.Code.2025._.IIITDM.Jabalpur._.Open.Source.Coding.Program.-.Google.Chrome.2025-07-13.14-21-14.mp4

💬 Notes for Reviewer

I have also updated PRs title's border .
It helps user to distinguish between PRs based on difficulties.


Related Issues

Closes #144

@AtharvPS13
Copy link
Copy Markdown
Contributor Author

@abhijeetw035 @rohansen856 please review !!

I have two issues(bugs/feature) in mind for bsoc-website . Can I open up the issues or should I discuss them in discord?

@abhijeetw035
Copy link
Copy Markdown
Collaborator

@abhijeetw035 @rohansen856 please review !!

I have two issues(bugs/feature) in mind for bsoc-website . Can I open up the issues or should I discuss them in discord?

Sure lets discuss on discord!

Copy link
Copy Markdown
Collaborator

@abhijeetw035 abhijeetw035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All difficulties are true by default, good, but if a user unchecks all, you’ll get an empty list. Maybe guard for at least one filter always active?

Comment thread src/views/SubmitPR.vue Outdated
@AtharvPS13
Copy link
Copy Markdown
Contributor Author

AtharvPS13 commented Jul 15, 2025

Ig it might also possible that user selects any difficulty and there might not be any pr with that difficulty.
So we should not guard any one filter.
So to tackle this I have updated code so that if there empty list then "No PRs found" will get rendered on screen.....

Proof:

BitByte.Summer.of.Code.2025._.IIITDM.Jabalpur._.Open.Source.Coding.Program.-.Google.Chrome.2025-07-15.17-55-33.mp4

@AtharvPS13 AtharvPS13 requested a review from abhijeetw035 July 15, 2025 12:31
@abhijeetw035
Copy link
Copy Markdown
Collaborator

Ig it might also possible that user selects any difficulty and there might not be any pr with that difficulty. So we should not guard any one filter. So to tackle this I have updated code so that if there empty list then "No PRs found" will get rendered on screen.....

Proof:
BitByte.Summer.of.Code.2025..IIITDM.Jabalpur..Open.Source.Coding.Program.-.Google.Chrome.2025-07-15.17-55-33.mp4

Yes better than guarding any one filer. PR looks good .
Actually filters were not working on changing in latest video you gave so to confirm Once give overall video that shows changes.

@AtharvPS13
Copy link
Copy Markdown
Contributor Author

AtharvPS13 commented Jul 16, 2025

Ig it might also possible that user selects any difficulty and there might not be any pr with that difficulty. So we should not guard any one filter. So to tackle this I have updated code so that if there empty list then "No PRs found" will get rendered on screen.....
Proof:
BitByte.Summer.of.Code.2025..IIITDM.Jabalpur..Open.Source.Coding.Program.-.Google.Chrome.2025-07-15.17-55-33.mp4

Yes better than guarding any one filer. PR looks good . Actually filters were not working on changing in latest video you gave so to confirm Once give overall video that shows changes.

Overall Video with all changes:

BitByte.Summer.of.Code.2025._.IIITDM.Jabalpur._.Open.Source.Coding.Program.-.Google.Chrome.2025-07-16.17-57-15.mp4

Also please dont forget to add labels to this pr!!

@abhijeetw035 abhijeetw035 merged commit a35e3f2 into bsoc-bitbyte:main Jul 16, 2025
@abhijeetw035
Copy link
Copy Markdown
Collaborator

LGTM! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add PR Search Bar & Label Filter in SubmitPR Page

2 participants