fix: bump Python to 3.10, drop archived selenium-wire, note webhook example needs Python 3.12#134
Open
MagMueller wants to merge 2 commits intomainfrom
Open
fix: bump Python to 3.10, drop archived selenium-wire, note webhook example needs Python 3.12#134MagMueller wants to merge 2 commits intomainfrom
MagMueller wants to merge 2 commits intomainfrom
Conversation
…xample needs Python 3.12
- browser-use-python: bump requires-python from 3.9 to 3.10 (generated models use
PEP 604 `str | None` union syntax which breaks on 3.9, contradicting metadata)
- docs(playwright): remove archived selenium-wire reference
(github.com/wkeeling/selenium-wire has been read-only since Jan 2024)
- docs(webhooks): note that the Python verify_webhook example requires Python 3.12+
because of f-string nested quotes in `separators=(',', ':')`
- regenerate llms.txt / llms-full.txt
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/cloud/llms-full.txt">
<violation number="1" location="docs/cloud/llms-full.txt:1882">
P2: The Hermes in-page link `#agent-self-registration` is ambiguous because this file now has multiple `## Agent Self-Registration` headings, so the link can jump to the wrong section.</violation>
</file>
<file name="docs/cloud/guides/webhooks.mdx">
<violation number="1" location="docs/cloud/guides/webhooks.mdx:40">
P2: The new note incorrectly claims this f-string requires Python 3.12+, but the shown syntax is valid on earlier versions (e.g., Python 3.11), so the docs now state a false version constraint.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
…ote, revert llms.txt regen - webhooks.mdx: the f-string uses different outer/inner quote chars (`"` vs `'`), so it works on Python 3.9+ — the 3.12+ claim was wrong. Remove the Note. - Revert llms.txt / llms-full.txt regeneration. Regenerating surfaced a pre-existing duplicate `## Agent Self-Registration` heading in two tutorial MDX files (hermes-agent and claude-code), which made the `#agent-self-registration` anchor ambiguous. That's out of scope for this PR; the docs team can regenerate llms.txt in a follow-up. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
3 issues found across 6 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/open-source/llms-full.txt">
<violation number="1">
P2: This new generic “Other models” section removes provider-specific setup details that are still present in the source docs.</violation>
<violation number="2">
P2: The Cloud API command table was changed to unsupported/undocumented `cloud connect` flags, diverging from the source CLI docs.</violation>
<violation number="3">
P2: The generated tab command table is out of sync with the canonical CLI docs and now documents different commands.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes surfaced by a 13-agent doc audit:
browser-use-pythonrequires-python:>=3.9→>=3.10. The generated models use PEP 604str | Noneunion syntax, which crashes on Python 3.9 withTypeError: Unable to evaluate type annotation 'str | None'. Stock macOS ships Python 3.9, so the current metadata is broken for any new user on a fresh machine.selenium-wirelink.github.com/wkeeling/selenium-wirehas been read-only since Jan 2024. The Playwright CDP bridge workaround is kept.verify_webhooksnippet uses an f-string with nested quotes (f"...{json.dumps(payload, separators=(',', ':'), ...)}") which is aSyntaxErroron Python < 3.12. Added a<Note>callout pointing at the fix instead of rewriting the snippet.Model-name fixes (hyphens → dots) were already landed in #116, so no changes needed there.
Also regenerated
llms.txt/llms-full.txt.Test plan
uv syncinbrowser-use-python/on Python 3.10<Note>Summary by cubic
Bump
browser-use-pythonto Python 3.10+ and clean up docs by removing the archivedselenium-wire. Also removed an incorrect Python 3.12 note from the webhook example and reverted accidental LLM index regeneration.Bug Fixes
requires-pythonto>=3.10andpyright.pythonVersionto3.10; simplifieduv.lockby dropping 3.9 markers.selenium-wire.llms.txt/llms-full.txtregen.Migration
browser-use-python.Written for commit ed01472. Summary will update on new commits.