security: harden publish workflow against Mini Shai-Hulud (pin + egress)#10
Merged
Conversation
c1535b1 to
853d435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Mini Shai-Hulud supply chain hardening campaign — closing OIDC hijack vectors in GitHub Actions publish pipelines across the brickhouse-tech org.
Changes
brickhouse-tech/.githubshared workflow refs (tests + publish) from@mainto SHA3c0bca8e1e161a6f61aee72413611b6fca239974permissions: contents: read+id-token: write(was entirely missing)permissionson the publish job for defense-in-depthThreat model
Unpinned
@mainrefs on shared workflows allow an attacker who pushes to the.githubrepo'smainbranch (or hijacks via OIDC) to inject arbitrary steps into every caller's publish run. Missing permissions means the GITHUB_TOKEN has default write-all scope — a much larger blast radius if compromised.Precedent
Same pattern already merged in:
Test plan
3c0bca8e1e161a6f61aee72413611b6fca239974matches a reviewed commit on brickhouse-tech/.github