Skip to content

security: harden publish workflow against Mini Shai-Hulud (pin + egress)#10

Merged
nmccready merged 1 commit into
masterfrom
security/shai-hulud-hardening
May 17, 2026
Merged

security: harden publish workflow against Mini Shai-Hulud (pin + egress)#10
nmccready merged 1 commit into
masterfrom
security/shai-hulud-hardening

Conversation

@nmccready
Copy link
Copy Markdown
Collaborator

Summary

Part of the Mini Shai-Hulud supply chain hardening campaign — closing OIDC hijack vectors in GitHub Actions publish pipelines across the brickhouse-tech org.

Changes

  • Pin both brickhouse-tech/.github shared workflow refs (tests + publish) from @main to SHA 3c0bca8e1e161a6f61aee72413611b6fca239974
  • Add top-level permissions: contents: read + id-token: write (was entirely missing)
  • Add per-job permissions on the publish job for defense-in-depth

Threat model

Unpinned @main refs on shared workflows allow an attacker who pushes to the .github repo's main branch (or hijacks via OIDC) to inject arbitrary steps into every caller's publish run. Missing permissions means the GITHUB_TOKEN has default write-all scope — a much larger blast radius if compromised.

Precedent

Same pattern already merged in:

Test plan

  • SHA 3c0bca8e1e161a6f61aee72413611b6fca239974 matches a reviewed commit on brickhouse-tech/.github
  • Publish workflow still triggers and delegates correctly to the shared workflow

@nmccready nmccready force-pushed the security/shai-hulud-hardening branch from c1535b1 to 853d435 Compare May 13, 2026 21:43
@nmccready nmccready merged commit 0a761c3 into master May 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant