[bug] google to chat completions and google to responses#204
Open
Caitlin Pinn (cpinn) wants to merge 2 commits intomainfrom
Open
[bug] google to chat completions and google to responses#204Caitlin Pinn (cpinn) wants to merge 2 commits intomainfrom
Caitlin Pinn (cpinn) wants to merge 2 commits intomainfrom
Conversation
Caitlin Pinn (cpinn)
requested review from
Alex Z (CLowbrow) and
Ken Jiang (knjiang)
Caitlin Pinn (cpinn)
removed request for
Alex Z (CLowbrow) and
Ken Jiang (knjiang)
Caitlin Pinn (cpinn)
requested review from
Alex Z (CLowbrow) and
Ken Jiang (knjiang)
Alex Z (CLowbrow)
approved these changes
Apr 30, 2026
Contributor
Alex Z (CLowbrow)
left a comment
Alex Z (CLowbrow)
left a comment
There was a problem hiding this comment.
Did you test this by sending requests through gateway with these tools and seeing that the functionality is the same? I'm worried about transforming tools provided by providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this small change to fix a parsing error. I believe the right location to fix this is in tools but I also noticed some changes in adapters and it is unclear to me where this change should appropriately live.
For google to open ai responses set code_interpreter property for codeExecution google property.
For google to open ai chat completions strip out the code_interpreter property as there appears to be no equivalent.
Fix the existing tests and remove the transform errors.