Conversation
Co-authored-by: Routhleck <88108241+Routhleck@users.noreply.github.com>
Co-authored-by: Routhleck <88108241+Routhleck@users.noreply.github.com>
Co-authored-by: Routhleck <88108241+Routhleck@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Joint second-order odes?
Improve JointEq error message for second-order ODEs and add documentation
Nov 3, 2025
Refreshed code cell outputs, execution counts, and execution metadata in the joint_equations.ipynb tutorial. Added print outputs for the second-order system and Jansen-Rit model examples, and updated function signatures and object references to reflect current execution results.
Routhleck
approved these changes
Nov 3, 2025
Member
Routhleck
left a comment
There was a problem hiding this comment.
LGTM.
@chaoming0625 If there are no issues, we will merge this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users implementing second-order ODE systems (e.g., Jansen-Rit neural mass model) encountered a cryptic error when using
JointEq: "Variable 'y3' has been used... Please change another name." The actual issue was incorrect function signature ordering, not a naming conflict.Changes
Error Message Enhancement
tare state variables; parameters aftertare dependenciestin exactly one derivative functionDocumentation
joint_equations.ipynbcovering second-order ODE systemsTests
test_second_order_odefor harmonic oscillator validationtest_second_order_ode_wrong_signatureto verify improved error messagingExample
Incorrect (from original issue):
Correct:
The new error message shows the current function signature and pattern guidance when this mistake occurs.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.