cleanup: replace em dashes, en dashes, and emoji shortcodes across codebase#57
Conversation
…debase. was going through the codebase and noticed a bunch of em dashes scattered everywhere — in comments, docs, js strings, even the meta tags. also found some en dashes and github emoji shortcodes in the pr receipt module. none of this breaks anything but it's inconsistent and looks like copy-paste artifacts. ### what changed - replaced all em dashes (—) with regular hyphens (-) — 51 instances across 12 files - replaced the one en dash (–) in card/readme.md (`10–30` → `10-30`) - removed `:small_blue_diamond:` and `:warning:` emoji shortcodes from receipt-md.js — the arrow symbol already conveys direction - meta tags, comments, docs, and js fallback strings all updated ### what didn't change - tests still pass (24/24) - no behavior changes, no refactors - left the bullet separator character (•) in the ui alone since that's intentional ### files touched index.html, card/render/*.js, card/lib/*.js, card/index.js, card/action.yml, card/README.md, README.md, tests/**/*.mjs, tests/fixtures/vault/*.md
|
@Mohammad-Faiz-Cloud-Engineer is attempting to deploy a commit to the braedonsaunders' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the careful work here - the diff is clean and tests pass. Going to pass on this one though. The em dashes aren't copy-paste artifacts; they're an intentional stylistic choice across the README, page title, OG meta tags, and card docs. Replacing them with hyphens is a typography downgrade for no functional gain. The emoji removal in If you spot anything functional you'd like to tackle, I'd be happy to look. Appreciate the contribution! |
2 participants
was going through the codebase and noticed a bunch of em dashes scattered everywhere, in comments, docs, js strings, even the meta tags. also found some en dashes and github emoji shortcodes in the pr receipt module. none of this breaks anything but it's inconsistent and looks like copy-paste artifacts.
what changed
10–30→10-30):small_blue_diamond:and:warning:emoji shortcodes from receipt-md.js, the arrow symbol already conveys directionwhat didn't change
files touched
index.html, card/render/.js, card/lib/.js, card/index.js, card/action.yml, card/README.md, README.md, tests/**/.mjs, tests/fixtures/vault/.md