Rename RawKvPair to RawKVPair for protobuf naming consistency#312
Merged
bootjp merged 2 commits intofeature/multi-raftfrom Feb 14, 2026
Merged
Rename RawKvPair to RawKVPair for protobuf naming consistency#312bootjp merged 2 commits intofeature/multi-raftfrom
bootjp merged 2 commits intofeature/multi-raftfrom
Conversation
Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Copilot
AI
changed the title
[WIP] WIP on addressing feedback for coordinator logic refactor
Rename RawKvPair to RawKVPair for protobuf naming consistency
Feb 14, 2026
bootjp
approved these changes
Feb 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the protobuf message RawKvPair to RawKVPair to achieve consistent acronym casing throughout the protobuf API definitions. The change aligns the message name with the RawKV service name, treating "KV" as a single acronym unit rather than mixed-case "Kv".
Changes:
- Renamed protobuf message from
RawKvPairtoRawKVPairin proto/service.proto - Regenerated all protobuf Go bindings with updated protoc toolchain (protoc v3.21.12, protoc-gen-go v1.36.11, protoc-gen-go-grpc v1.6.1)
- Updated adapter/grpc.go to reference the renamed type
pb.RawKVPair
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| proto/service.proto | Renamed RawKvPair message to RawKVPair for naming consistency |
| proto/service.pb.go | Regenerated Go protobuf bindings with renamed type and updated protoc versions |
| proto/service_grpc.pb.go | Regenerated gRPC stubs with updated protoc-gen-go-grpc version (v1.6.1) |
| proto/internal.pb.go | Regenerated with updated protoc toolchain |
| proto/internal_grpc.pb.go | Regenerated with updated protoc-gen-go-grpc version |
| proto/distribution.pb.go | Regenerated with updated protoc toolchain |
| proto/distribution_grpc.pb.go | Regenerated with updated protoc-gen-go-grpc version |
| adapter/grpc.go | Updated type references from pb.RawKvPair to pb.RawKVPair |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses naming inconsistency in protobuf definitions where
RawKvPairused mixed-case acronym style while the service nameRawKVand other messages follow the convention of treating acronyms as single words.Changes
RawKvPair→RawKVPairmessage definitionpb.RawKVPairThis aligns with the existing
RawKVservice name and standard protobuf conventions.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.