Skip to content

Rename RawKvPair to RawKVPair for protobuf naming consistency#312

Merged
bootjp merged 2 commits intofeature/multi-raftfrom
copilot/sub-pr-304
Feb 14, 2026
Merged

Rename RawKvPair to RawKVPair for protobuf naming consistency#312
bootjp merged 2 commits intofeature/multi-raftfrom
copilot/sub-pr-304

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

Addresses naming inconsistency in protobuf definitions where RawKvPair used mixed-case acronym style while the service name RawKV and other messages follow the convention of treating acronyms as single words.

Changes

  • proto/service.proto: Renamed RawKvPairRawKVPair message definition
  • adapter/grpc.go: Updated type references to pb.RawKVPair
  • Regenerated all protobuf Go code with updated naming
// Before
message RawKvPair {
  bytes key = 1;
  bytes value = 2;
}

// After
message RawKVPair {
  bytes key = 1;
  bytes value = 2;
}

This aligns with the existing RawKV service name and standard protobuf conventions.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 14, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Copilot AI changed the title [WIP] WIP on addressing feedback for coordinator logic refactor Rename RawKvPair to RawKVPair for protobuf naming consistency Feb 14, 2026
Copilot AI requested a review from bootjp February 14, 2026 19:18
@bootjp bootjp marked this pull request as ready for review February 14, 2026 19:20
Copilot AI review requested due to automatic review settings February 14, 2026 19:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the protobuf message RawKvPair to RawKVPair to achieve consistent acronym casing throughout the protobuf API definitions. The change aligns the message name with the RawKV service name, treating "KV" as a single acronym unit rather than mixed-case "Kv".

Changes:

  • Renamed protobuf message from RawKvPair to RawKVPair in proto/service.proto
  • Regenerated all protobuf Go bindings with updated protoc toolchain (protoc v3.21.12, protoc-gen-go v1.36.11, protoc-gen-go-grpc v1.6.1)
  • Updated adapter/grpc.go to reference the renamed type pb.RawKVPair

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
proto/service.proto Renamed RawKvPair message to RawKVPair for naming consistency
proto/service.pb.go Regenerated Go protobuf bindings with renamed type and updated protoc versions
proto/service_grpc.pb.go Regenerated gRPC stubs with updated protoc-gen-go-grpc version (v1.6.1)
proto/internal.pb.go Regenerated with updated protoc toolchain
proto/internal_grpc.pb.go Regenerated with updated protoc-gen-go-grpc version
proto/distribution.pb.go Regenerated with updated protoc toolchain
proto/distribution_grpc.pb.go Regenerated with updated protoc-gen-go-grpc version
adapter/grpc.go Updated type references from pb.RawKvPair to pb.RawKVPair

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bootjp bootjp merged commit 873c0c9 into feature/multi-raft Feb 14, 2026
10 checks passed
@bootjp bootjp deleted the copilot/sub-pr-304 branch February 14, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants