Open
Conversation
Author
|
@apolukhin, please have a look at this draft. Note, I was using CMake and |
Member
|
Tests are missing. You will need to write some b2 scripts: follow this sample Lines 80 to 93 in 344f6ba Lines 34 to 40 in 344f6ba After that adjust https://github.com/boostorg/stacktrace/blob/develop/test/Jamfile.v2 by adding each of the tests with libdwfl |
This commit adds an implementation based on libdwfl from elfutils. Implements boostorg#176
apolukhin
requested changes
Jan 24, 2025
Member
apolukhin
left a comment
There was a problem hiding this comment.
Sorry for the long delay. The PR looks very good!
A few more things to fix:
- As I see in CI runs the
dwlibrary is not found and the new functionality is not tested. Please adjust the content of.github/workflows/directory to test the new implementation - One of the Boost specific linters complains that the build/has_dwfl.cpp, include/boost/stacktrace/detail/libdwfl_impls.hpp, src/dwfl.cpp files have no
Copyrightnotes. Copypaste the Copyright message and place your name in it (or place my name if you wish to remain anonymous)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an implementation based on
libdwflfromelfutils.Implements #176