feat(patch_set): PatchSet::parse_bytes for raw byte input#66
Merged
bmwill merged 8 commits intobmwill:masterfrom Apr 16, 2026
Merged
feat(patch_set): PatchSet::parse_bytes for raw byte input#66bmwill merged 8 commits intobmwill:masterfrom
PatchSet::parse_bytes for raw byte input#66bmwill merged 8 commits intobmwill:masterfrom
Conversation
Preparation for `PatchSet::parse_bytes(&[u8])` support. No behavior change.
Move dispatch logic to free functions, so we can have private trait bound on them.
Avoid lossy UTF-8 conversion of diff output so non-UTF-8 content round-trips correctly.
weihanglo
force-pushed
the
patchset-bytes
branch
from
c1752c7 to
f6643d9
Compare
Contributor
Author
|
Rebased to resolve the merge conflict! |
Owner
|
Thanks i had just finished a review and was going to do that myself, appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire idea is
PatchSet::parse_bytesso that some non-UTF8 hunk that Git doesn't consider as binary patch can still be safely parsed an applied.With this PR, our history replay test no longer skip any non-UTF8 patches.
Fixes #63