node: move proposal signing into validator client#997
Open
zclawz wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Validation complete ✅
Log: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the TODO in
pkgs/node/src/chain.zigaround proposal signing/proof construction by moving validator-owned work out ofchain.zigand intovalidator_client.zig.Changes:
BeamChain.proposeImpl.ValidatorClient.buildProposalOutput, which:GossipMessage.block).BeamNodeso off-loop proposal workers can hand signed block output back to the interval tick.BeamNoderemains the publisher for blocks/attestations/aggregations.Tracking topic: https://t.me/zeamETH/7164
Validation
Running:
zig fmt --check pkgs/node/src/chain.zig pkgs/node/src/node.zig pkgs/node/src/validator_client.zigzig build test --summary all --color offI will update this PR comment when the full test run completes.