Skip to content

fix partial reveal from map stations #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blkerby merged 1 commit into from
Apr 21, 2026
Merged

fix partial reveal from map stations #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified patches/ips/map_progress_maintain.ips
View file
Open in desktop
Binary file not shown.
14 changes: 7 additions & 7 deletions patches/src/map_progress_maintain.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ activate_map_station_hook:
; since those would not show correctly in the partially-revealed palette:
; TODO: look into removing this. It shouldn't be needed anymore, since we switched
; to using the "cross-area reveal" table to cover these same-area reveal as well.
lda $829727, x
ora $702000, x
sta $702000, x
;lda $829727, x
;ora $702000, x
;sta $702000, x
inx
inx
dey
Expand Down Expand Up @@ -188,7 +188,7 @@ hook_mark_tile_above:

rts

warnpc !bank_90_freespace_end
assert pc() <= !bank_90_freespace_end

;;;; $943D: Load pause menu map tilemap ;;;
org $82943D
Expand All @@ -210,7 +210,7 @@ load_pause_map_tilemap:
STA $02 ;/
BRA .set_dst

warnpc $82945C
assert pc() <= $82945C
org $82945C ; We keep this instruction in the same place so that item_dots_disappear can hook into it
.set_dst
LDA #$4000 ;\
Expand Down Expand Up @@ -299,7 +299,7 @@ org $82945C ; We keep this instruction in the same place so that item_dots_
BRA .BRANCH_NEXT ; Go to BRANCH_NEXT


warnpc $829628
assert pc() <= $829628

; For HUD mini-map drawing, load map revealed bits (persisted across deaths/reloads)
; in place of map data bits (which are irrelevant since whole map is revealed):
Expand Down Expand Up @@ -405,4 +405,4 @@ fix_mb:
ldx #$0122
rtl

warnpc !bank_a4_free_space_end
assert pc() <= !bank_a4_free_space_end
Loading