Fix multi-channel SSH operations by respecting session I/O needs#55
Draft
krystophny wants to merge 2 commits intobk-rs:mainfrom
Draft
Fix multi-channel SSH operations by respecting session I/O needs#55krystophny wants to merge 2 commits intobk-rs:mainfrom
krystophny wants to merge 2 commits intobk-rs:mainfrom
Conversation
Add comprehensive guidance file for Claude Code AI assistant including: - Development commands for linting, formatting, building and testing - Architecture overview of async-ssh2-lite and bb8-async-ssh2-lite crates - Integration test instructions with Docker-based OpenSSH servers - Key library capabilities and runtime support details 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolves assertion failures when using multiple channels on a single SSH session. The fix changes the async I/O waiting logic to respect what the session needs (aggregate state of all channels) rather than asserting on individual operation expectations. Changes: - Remove assertions that expected_block_directions matches sess.block_directions() - Always wait for I/O that the session requires, enabling proper multiplexing - Add comprehensive test suite covering sequential, concurrent, and stress scenarios - Verify data integrity and no cross-channel contamination This enables SSHBind and similar applications to use multiple channels on one session through proper async serialization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes assertion failures when using multiple channels on a single SSH session, enabling proper async I/O multiplexing.
Problem
Applications like SSHBind that create multiple channels on a single SSH session were hitting assertion failures in the async I/O code:
The issue occurred because the code was asserting that
sess.block_directions()(session's aggregate I/O needs) matchedexpected_block_directions(individual operation expectations). With multiple channels, these naturally differ.Solution
Always wait for whatever I/O the session needs, regardless of what the current operation expects:
expected_block_directionsmatchessess.block_directions()sess.block_directions()which represents the aggregate state of all channelsChanges
impl_tokio.rsandimpl_async_io.rsto remove blocking assertionstest_audit_multichannel.rs) covering:Testing
All existing tests pass. New tests verify:
Compatibility
🤖 Generated with Claude Code