ci: update actions off deprecated Node 20 runtime, run tests on master#22
Merged
Merged
Conversation
Bump actions/checkout and actions/setup-python to v6 and codecov/codecov-action to v6 (their current latest majors, on a supported Node runtime) so GitHub stops flagging the deprecated Node 20 action runtime. Also rename codecov's deprecated `file` input to `files`.
The workflow triggered on main/develop, but this repo's default branch is master, so the test job did not run on pushes or PRs to master. Point the triggers at master so CI actually gates changes.
This was referenced Jun 6, 2026
Merged
bjhiltbrand
pushed a commit
that referenced
this pull request
Jun 6, 2026
The test workflow started running on master (#22) and surfaced three failures: - ruff UP031: cognito_timestamp used percent formatting; switched to an f-string with identical output. - black: reformatted device_srp.py, auth.py, client.py and the device tests to satisfy black --check (client.py was never black-compliant; CI just never ran black on master before). - pytest: test_from_dict_full and test_get_vehicle_status_success fed a flat dict the model never reads (VehicleStatus.from_dict parses the nested last_known_state.controller), so they asserted against unparsed values. Rewrote both to the real nested payload and the values the model actually produces. ruff check, black --check and pytest (79 passed) all pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CI maintenance, two small fixes to the workflows:
Clear the deprecated Node 20 action runtime warning. Bump to the current latest majors (on a supported Node runtime):
actions/checkoutv4 -> v6 (test.yml), v3 -> v6 (python-publish.yml)actions/setup-pythonv4 -> v6 (test.yml), v3 -> v6 (python-publish.yml)codecov/codecov-actionv3 -> v6, and rename its deprecatedfile:input tofiles:pypa/gh-action-pypi-publishis a Docker action (no Node), left as is.Run tests on
master. The triggers pointed atmain/develop, but this repo's default branch ismaster, so the test job was not running on pushes or PRs tomaster. Repointed atmasterso CI actually gates changes.Why
GitHub now warns that the Node 20 action runtime is deprecated, and the test workflow was effectively dormant for
master-targeted PRs.