Skip to content

kernel: Chainparams and headerssync updates from Core #34677#291

Open
luke-jr wants to merge 6 commits into
bitcoinknots:29.x-knotsfrom
luke-jr:checkpoint_update_pr34677-29+knots
Open

kernel: Chainparams and headerssync updates from Core #34677#291
luke-jr wants to merge 6 commits into
bitcoinknots:29.x-knotsfrom
luke-jr:checkpoint_update_pr34677-29+knots

Conversation

@luke-jr

@luke-jr luke-jr commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Backport of bitcoin#34677 on Knots 29

When reviewing, please verify every change's correctness, not only that it works. These instructions may help

Also open to conceptual input on whether to apply the non-mainnet updates (currently the PR applies them and rolls them back)

@luke-jr luke-jr added the rebase Existing Knots patches, rebased for the latest codebase label Mar 25, 2026

@kwsantiago kwsantiago left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ea4e349

@kwsantiago kwsantiago left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independently verified all mainnet values against a fully synced Knots 29.3 node:

defaultAssumeValid (height 938343):

  • getblockhash 938343 -> 00000000000000000000ccebd6d74d9194d8dcdc1d177c478e094bfad51ba5ac

nMinimumChainWork:

  • getblockheader chainwork -> 0000000000000000000000000000000000000001128750f82f4c366153a3a030

chainTxData (getchaintxstats 4096 @ 938343):

  • nTime: 1772055173
  • tx_count: 1315805869
  • dTxRate: 5.40111006496122

assumeutxo (dumptxoutset rollback=935000):

  • txoutset_hash: e4b90ef9eae834f56c4b64d2d50143cee10ad87994c614d7d04125e2a6025050
  • base_hash: 0000000000000000000147034958af1652b2b91bba607beacc5e72a56f0fb5ee
  • nchaintx: 1305397408

All values match the PR.

@Retropex Retropex left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All value match with my own node.

consensus.nMinimumChainWork -> 0000000000000000000000000000000000000001128750f82f4c366153a3a030
consensus.defaultAssumeValid -> 00000000000000000000ccebd6d74d9194d8dcdc1d177c478e094bfad51ba5ac

hash_serialized -> e4b90ef9eae834f56c4b64d2d50143cee10ad87994c614d7d04125e2a6025050
m_chain_tx_count -> 1305397408
blockhash -> 0000000000000000000147034958af1652b2b91bba607beacc5e72a56f0fb5ee

nTime -> 1772055173
tx_count -> 1315805869
dTxRate -> 5.40111006496122

@Retropex

Copy link
Copy Markdown

Also open to conceptual input on whether to apply the non-mainnet updates

Is there any reason not to apply them?

@luke-jr

luke-jr commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator Author

Also open to conceptual input on whether to apply the non-mainnet updates

Is there any reason not to apply them?

Lack of review, at least :)

@Retropex

Copy link
Copy Markdown

Then I will verify all value for other networks and bring a review shortly

@Retropex

Copy link
Copy Markdown

All value match with my own nodes freshly synced.

testnet3:

consensus.nMinimumChainWork -> 0000000000000000000000000000000000000000000017dde1c649f3708d14b6
consensus.defaultAssumeValid -> 000000007a61e4230b28ac5cb6b5e5a0130de37ac1faf2f8987d2fa6505b67f4

hash_serialized -> ce6bb677bb2ee9789c4a1c9d73e6683c53fc20e8fdbedbdaaf468982a0c8db2a
m_chain_tx_count -> 536078574
blockhash -> 00000000000000f4971a7fb37fbdff89315b69a2e1920c467654a382f0d64786

nTime -> 1772051651
tx_count -> 536108416
dTxRate -> 0.02691479016257117

testnet4:

consensus.nMinimumChainWork -> 0000000000000000000000000000000000000000000009a0fe15d0177d086304
consensus.defaultAssumeValid -> 0000000002368b1e4ee27e2e85676ae6f9f9e69579b29093e9a82c170bf7cf8a

hash_serialized -> 10b05d05ad468d0971162e1b222a4aa66caca89da2bb2a93f8f37fb29c4794b0
m_chain_tx_count -> 14141057
blockhash -> 000000000bd2317e51b3c5794981c35ba894ce27d3e772d5c39ecd9cbce01dc8

nTime -> 1772013387
tx_count -> 14191421
dTxRate -> 0.01848579579528412

signet:

consensus.nMinimumChainWork -> 00000000000000000000000000000000000000000000000000000b463ea0a4b8
consensus.defaultAssumeValid -> 00000008414aab61092ef93f1aacc54cf9e9f16af29ddad493b908a01ff5c329

hash_serialized -> 97267e000b4b876800167e71b9123f1529d13b14308abec2888bbd2160d14545
m_chain_tx_count -> 28547497
blockhash -> 0000000577f2741bb30cd9d39d6d71b023afbeb9764f6260786a97969d5c9ac0

nTime -> 1772055248
tx_count -> 28676833
dTxRate -> 0.06736623436338929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rebase Existing Knots patches, rebased for the latest codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants