Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Snapshot Command#25

Open
bitcoiner-dev wants to merge 1 commit intomasterfrom
sentinel-fix-path-traversal-14316805293302288970
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Snapshot Command#25
bitcoiner-dev wants to merge 1 commit intomasterfrom
sentinel-fix-path-traversal-14316805293302288970

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The snapshot command's run function directly interpolated user-supplied values (args.name) into file paths: snap_dir.join(format!("{name}.json")). Because there was no validation on the name argument, this effectively created a Path Traversal vulnerability where sequences like ../ could be used to write data or read arbitrary json data from outside the snapshot directory.
🎯 Impact: This allows arbitrary file overwrites and potential system compromise depending on what data the application attempts to read or parse from the user-controlled file location on disk.
πŸ”§ Fix: Added a strict validation function validate_file_name to src/utils.rs that ensures file names are limited strictly to ASCII alphanumeric characters, underscores, and dashes. src/commands/snapshot.rs was updated to call this validation before processing snapshot save or restore actions.
βœ… Verification: Ran cargo test and cargo clippy which passed. Validated that providing valid strings works as expected, and anything else results in an error.


PR created automatically by Jules for task 14316805293302288970 started by @bitcoiner-dev

Added explicit validation via `validate_file_name` in `src/utils.rs` to enforce strict character limits (alphanumeric, dashes, underscores) on the snapshot name. The command `src/commands/snapshot.rs` was then updated to apply this validation prior to reading or writing snapshots. This prevents arbitrary file overwrites and unauthorized file access resulting from untrusted input.

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant