Extend supported Firebase Authentication#47
Draft
LaszloDev wants to merge 2 commits intobenwinding:masterfrom
Draft
Extend supported Firebase Authentication#47LaszloDev wants to merge 2 commits intobenwinding:masterfrom
LaszloDev wants to merge 2 commits intobenwinding:masterfrom
Conversation
Closed
Owner
|
Hey @LaszloDev, Looks like a great start, I like the way you've implemented the https://github.com/firebase/firebaseui-web It's a popular way to implement different authentication methods with the Firebase sdk and might make things a bit easier (but I'm not sure). Thanks again. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a concept for extending and providing support for multiple Firebase authentication modes.
Default will still be
firebase.auth.signInWithEmailAndPassword(), but this PR opens the possibility to write your own LoginPage-component which can pass amodeto the React-Admin LOGIN-action. Based on this mode different Firebase authentications will be possible.In the first stepp I implement the mode
link, which refers to Firebase "Email Link" authentication method. (Find out more here https://firebase.google.com/docs/auth/web/email-link-auth)Open tasks / Bugs:
actionCodeSettings-objectRelated Issues:
Let me know if you see issues or alternative ways to implement this extension.