Skip to content

Fix gungraun benchmark name (#778)#780

Open
gamma0987 wants to merge 1 commit intobencherdev:develfrom
gamma0987:fix-gungraun-benchmark-name
Open

Fix gungraun benchmark name (#778)#780
gamma0987 wants to merge 1 commit intobencherdev:develfrom
gamma0987:fix-gungraun-benchmark-name

Conversation

@gamma0987
Copy link
Copy Markdown
Contributor

@gamma0987 gamma0987 commented Apr 9, 2026

Fix gungraun benchmark name parsing to exclude (truncated) descriptions

This PR fixes the gungraun adapter to correctly parse benchmark names by using only the module path and optional id, excluding the description. Previously, the entire first line(s) (including truncated descriptions) was used as the benchmark name. The benchmark name is now also much shorter which makes it very unlikely to hit the MAX_BENCHMARK_NAME_LEN limit.

  • Updated parsing logic in single_benchmark() to properly extract benchmark names.
  • Updated tests:
    • Fixed existing test expectations (benchmark names no longer include descriptions)
    • Added test covering all valid ID formats

Before: file::group::function id:some description possibly truncated with ...
After: file::group::function id

Fixes: #778
Related: #638

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

🐰 Bencher Report

Branchfix-gungraun-benchmark-name
Testbedintel-v1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
Adapter::Json📈 view plot
🚷 view threshold
4.48 µs
(-0.87%)Baseline: 4.52 µs
4.68 µs
(95.70%)
Adapter::Magic (JSON)📈 view plot
🚷 view threshold
4.36 µs
(-0.62%)Baseline: 4.39 µs
4.56 µs
(95.62%)
Adapter::Magic (Rust)📈 view plot
🚷 view threshold
25.36 µs
(+0.41%)Baseline: 25.25 µs
26.37 µs
(96.15%)
Adapter::Rust📈 view plot
🚷 view threshold
3.39 µs
(-0.60%)Baseline: 3.41 µs
3.55 µs
(95.42%)
Adapter::RustBench📈 view plot
🚷 view threshold
3.37 µs
(-0.89%)Baseline: 3.41 µs
3.54 µs
(95.27%)
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant