Upcoming events and layout fixes#761
Merged
freakboy3742 merged 5 commits intobeeware:mainfrom Mar 10, 2026
Merged
Conversation
freakboy3742
requested changes
Mar 10, 2026
Member
freakboy3742
left a comment
There was a problem hiding this comment.
Looks good - one minor suggestion, and one request for a related tweak: you've added padding at the top of the blog post title to account for the (absent) breadcrumbs; it looks like there's a similar need on the News/Events/Resources landing page.
docs/en/index.md
Outdated
Comment on lines
125
to
131
| {% if upcoming_events(files) == None %} | ||
|
|
||
| Nothing at the moment... | ||
|
|
||
| {% else %} | ||
|
|
||
| {{ upcoming_events(files) }} |
Member
There was a problem hiding this comment.
As written, this will invoke the macro twice. That's not a huge problem, but it's one we can avoid with {% set %}
Suggested change
| {% if upcoming_events(files) == None %} | |
| Nothing at the moment... | |
| {% else %} | |
| {{ upcoming_events(files) }} | |
| {% set events = upcoming_events(files) %} | |
| {% if events %} | |
| {{ events }} | |
| {% else %} | |
| Nothing at the moment... |
Contributor
Author
There was a problem hiding this comment.
I didn't commit this directly because I think there still needs to be whitespace around the string for translation to not pull the Jinja into the translation string.
freakboy3742
approved these changes
Mar 10, 2026
Member
freakboy3742
left a comment
There was a problem hiding this comment.
👍 Looks awesome - thanks for those fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macros.pywhich means it will now be translated.PR Checklist: