-
-
Notifications
You must be signed in to change notification settings - Fork 3
Allow --copy to accept individual files alongside directories #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bcomnes
wants to merge
4
commits into
master
Choose a base branch
from
fix/copy-files-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−18
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a9613c4
Allow --copy to accept individual files alongside directories
bcomnes da713b0
Rename copyDirs to copyGlobs in buildCopy, add file path tests
bcomnes 6e66ea9
Fix error message to say 'copy path' instead of 'copy folders'
bcomnes adedcf3
Fix ambiguous test path, update bin help text and README to mention f…
bcomnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,41 @@ | ||
| import { test } from 'node:test' | ||
| import assert from 'node:assert' | ||
| import { mkdtemp, writeFile, rm } from 'node:fs/promises' | ||
| import { join } from 'node:path' | ||
| import os from 'node:os' | ||
| import { getCopyDirs } from './index.js' | ||
|
|
||
| test.describe('build-copy', () => { | ||
| test('getCopyDirs returns correct src/dest pairs', async () => { | ||
| const copyDirs = getCopyDirs(['fixtures']) | ||
| test('getCopyDirs appends ** for non-existent paths', async () => { | ||
| const dir = await mkdtemp(join(os.tmpdir(), 'domstack-copy-test-')) | ||
| const missingPath = join(dir, 'does-not-exist') | ||
| try { | ||
| const copyDirs = await getCopyDirs([missingPath]) | ||
| assert.deepStrictEqual(copyDirs, [join(missingPath, '**')]) | ||
| } finally { | ||
| await rm(dir, { recursive: true, force: true }) | ||
| } | ||
| }) | ||
|
|
||
| test('getCopyDirs returns file path as-is for existing files', async () => { | ||
| const dir = await mkdtemp(join(os.tmpdir(), 'domstack-copy-test-')) | ||
| const file = join(dir, 'sw.js') | ||
| try { | ||
| await writeFile(file, 'self.addEventListener("fetch", () => {})') | ||
| const result = await getCopyDirs([file]) | ||
| assert.deepStrictEqual(result, [file]) | ||
| } finally { | ||
| await rm(dir, { recursive: true, force: true }) | ||
| } | ||
| }) | ||
|
|
||
| assert.deepStrictEqual(copyDirs, ['fixtures/**']) | ||
| test('getCopyDirs appends ** for existing directories', async () => { | ||
| const dir = await mkdtemp(join(os.tmpdir(), 'domstack-copy-test-')) | ||
| try { | ||
| const result = await getCopyDirs([dir]) | ||
| assert.deepStrictEqual(result, [join(dir, '**')]) | ||
| } finally { | ||
| await rm(dir, { recursive: true, force: true }) | ||
| } | ||
| }) | ||
|
bcomnes marked this conversation as resolved.
|
||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.