Conversation
Coverage Report for CI Build 24619423454Coverage remained the same at 91.469%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Adds a new “Layout composition pitfalls” subsection to the README to warn about common silent failure modes when composing nested layouts.
Changes:
- Documented the need to explicitly forward
scriptsandstylesto avoid silently dropping CSS/JS bundles. - Added an example showing how to extend/modify
varsbefore forwarding to a base layout. - Added a checklist-style example calling out forwarding
page,pages, andworkerswhen the base layout relies on them.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace rootLayout/wrappedContent/wrapContent with identifiers that are actually defined in the surrounding context (defaultRootLayout and children), making the snippets copy-pasteable and consistent with the nested layout example above.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… name collision Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closes #232
The nested layouts section shows the correct pattern but does not warn about the ways it can silently go wrong. Three pitfalls trip up most users composing layouts for the first time:
scriptsandstylesto the base layout drops all CSS and JS bundles from the page with no error message.page,pages, orworkers, those params must also be forwarded explicitly.This adds a "Layout composition pitfalls" subsection with concrete right/wrong examples for each case.