Pass through cpu to rules based toolchains#702
Open
keith wants to merge 1 commit intobazelbuild:mainfrom
Open
Conversation
As mentioned in bazelbuild#327 (comment) there are still many places using this. I'm trying to convert the Apple toolchain to be rules based and we have to allow that repo to determine this since it defines custom constraints and custom platforms that define what "CPU" value should be set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in
#327 (comment)
there are still many places using this. I'm trying to convert the Apple
toolchain to be rules based and we have to allow that repo to determine
this since it defines custom constraints and custom platforms that
define what "CPU" value should be set.