Add supports_interface_shared_libraries to cc_shared_library#680
Open
keith wants to merge 1 commit intobazelbuild:mainfrom
Open
Add supports_interface_shared_libraries to cc_shared_library#680keith wants to merge 1 commit intobazelbuild:mainfrom
keith wants to merge 1 commit intobazelbuild:mainfrom
Conversation
Member
Author
|
i could split the unix toolchain fix up but it was nice to verify with this new support |
Member
Author
|
this is still off by default and requires users pass |
keith
force-pushed
the
ks/add-supports_interface_shared_libraries-to-cc_shared_library
branch
2 times, most recently
from
276eb04 to
03edcaa
Compare
This also backfills tests and fixes this in the default unix toolchain
keith
force-pushed
the
ks/add-supports_interface_shared_libraries-to-cc_shared_library
branch
from
03edcaa to
c7e4c50
Compare
Member
Author
|
this working on macOS depends on #675 |
Member
Author
|
cc @fmeum in case there was a reason not to do this originally |
Collaborator
|
I don't see why it shouldn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also backfills tests and fixes this in the default unix toolchain