Skip to content

Put progress bar behind the install button#1409

Open
kolunmi wants to merge 18 commits intomainfrom
progress-bar-in-controls
Open

Put progress bar behind the install button#1409
kolunmi wants to merge 18 commits intomainfrom
progress-bar-in-controls

Conversation

@kolunmi
Copy link
Copy Markdown
Collaborator

@kolunmi kolunmi commented Apr 13, 2026

Screencast.From.2026-04-12.21-18-42.mp4

@bertob

@AlexanderVanhee
Copy link
Copy Markdown
Collaborator

AlexanderVanhee commented Apr 13, 2026

The button seems to lack a hover and active state, I would put the "Install" and "Cancel" text in a stack so the width of the button doesn't jump when the state changes. The inner bar is way to wide on mobile when in the pending state

@kolunmi
Copy link
Copy Markdown
Collaborator Author

kolunmi commented Apr 13, 2026

@AlexanderVanhee fixed the jumping problem. I've discovered more places wdgt needs improvements along the way 🐹

@kolunmi kolunmi requested a review from AlexanderVanhee April 13, 2026 09:14
@AlexanderVanhee AlexanderVanhee marked this pull request as ready for review April 13, 2026 09:17
@AlexanderVanhee AlexanderVanhee marked this pull request as draft April 13, 2026 09:17
@kolunmi kolunmi marked this pull request as ready for review April 13, 2026 09:18
@kolunmi kolunmi marked this pull request as draft April 13, 2026 09:21
@kolunmi
Copy link
Copy Markdown
Collaborator Author

kolunmi commented Apr 13, 2026

ok worky

@bertob
Copy link
Copy Markdown
Contributor

bertob commented Apr 15, 2026

A few points of feedback from Matrix, so they don't get lost:

  • Decrease the around padding of the inner pill in the initial loading state
  • There's a 2-3s state at the end where the progress bar is full and static, which looks like a different style for the install button. Maybe we should stall a little bit before the end, and only transition to complete when we're ready to move on.
  • When uninstalling an app there's a 2s delay before the buttons are replaced by the Cancel button, it'd be good to have immedate feedback instead

@bertob
Copy link
Copy Markdown
Contributor

bertob commented Apr 17, 2026

A few more things I came across:

  • The new progress button is not used on the Addons dialog
  • By cancelling the install right as it's about to be complete you can end up in a limbo state where the app is (presumably) installed, but there's still the Install button rather than Open/Uninstall. In that state clicking Install does nothing, it just glitches for a second and then goes back to Install
Screencast.From.2026-04-17.13-13-49.webm

@kolunmi kolunmi marked this pull request as ready for review April 18, 2026 21:51
@bertob
Copy link
Copy Markdown
Contributor

bertob commented Apr 20, 2026

One more small nitpick: In the initial state where the inner pill is just going back and forth, I'd make that inner pill a bit less wide. Other than that and dropping the global progress bar this looks good to go from my side :)

@notaf0e
Copy link
Copy Markdown

notaf0e commented Apr 20, 2026

Another piece of feedback related to this. If the app is waiting to be installed in queue I believe the button should instead display "in queue" with either no progress bar, or instead bouncing from one side to the other like in the video at the start. Keep up the beautiful work! <3

@kolunmi
Copy link
Copy Markdown
Collaborator Author

kolunmi commented Apr 20, 2026

@bertob how's this look for the inner pill width?

Screencast.From.2026-04-20.15-50-06.mp4

@kolunmi
Copy link
Copy Markdown
Collaborator Author

kolunmi commented Apr 21, 2026

I feel that perhaps there should be a fourth state for when the download gets cancelled

currently it waits for the backend to finish cancelling before showing anything, which can often be delayed if a network operation is ongoing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants