fix(storage): avoid panic when pruning headers without static files#8
Open
fix(storage): avoid panic when pruning headers without static files#8
Conversation
Author
|
CI is green. This avoids a potential panic when pruning headers in environments without any header static files yet, and includes a regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid a potential panic in DatabaseProvider::remove_blocks_above when no header static files exist yet.
Motivation
The code currently uses �xpect(...) on get_highest_static_file_block(Headers), which can panic in a fresh/static-file-less environment. This change makes the operation a no-op for static file pruning when there is nothing to prune.
Changes