feat(ui): align profile, edit-profile & QR sheet with iOS#589
Open
dmnyc wants to merge 4 commits into
Open
Conversation
Port of wisp-ios#360. Adds CLINK Offers (noffer1…) payment support: - Noffer: bech32 + TLV decoder, pricing types (fixed / variable / spontaneous), isNofferString / stripNostrPrefix helpers - NofferClient: kind-21001 NIP-44 RPC on the offer's relay with code-3 expired/moved latest-retry - NofferPaySheet + NofferCard: shared pay sheet that pays via the active wallet or falls back to a scannable bare-noffer QR - Notes: RichContent detects noffer tokens and renders a Pay-offer card - Profiles: clink_offer parsed tolerantly from kind-0, editor field, Pay-offer header button, offer QR inside the Lightning tab with a contextual address/offer switch - Wallet send: noffer detection routes through the native amount → confirm flow; fixed-price offers skip straight to confirm - Tests: decoder round-trip coverage mirroring the CLINK spec TLVs Spec: https://github.com/shocknet/CLINK/blob/main/specs/clink-offers.md
The NoteActions built for DM conversations, group DMs, group rooms, and search results never set onPayInvoice, so the noffer pay sheet (and lightning invoice cards) on those surfaces degraded to "Connect a wallet to pay" even with an active wallet.
- Map noffer payment hashes to the offer's service pubkey via ZapSender.persistRecipient in both pay paths, so wallet history resolves the payee's profile (name + avatar) like zaps do - Show the offer service's profile name on the wallet amount page and in the confirm-page description fallback - Make NofferPaySheet full viewport height (status-bar inset so the drag handle clears camera cutouts), matching the iOS pay modal - ProfileRepository schema migration: reset cached profile timestamps once so kind-0s re-parse with the new clinkOffer field — stale pre-upgrade cache entries otherwise never pick it up
- Profile QR sheet: iOS-style segmented pill tabs instead of Material underline tabs; full viewport height with status-bar inset; profile avatar in the center of the Lightning/offer QR (bolt icon only as fallback); pager fills remaining height with top-aligned pages so content no longer shifts when switching tabs - Edit profile: tappable banner + avatar previews that open the gallery picker (camera badge, inline upload spinner); raw image URLs and the CLINK offer field moved into a collapsible Advanced section, matching the iOS editor - Profile overflow menu: replaced Copy Profile JSON with Share Profile (njump.me link via share sheet) and Copy npub, matching iOS; Add to List and Block/Unblock remain for other profiles
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profile-screen and QR-sheet styling parity with the iOS app, split out from the CLINK feature work per review hygiene. Stacked on #588 — merge that first; until then this diff includes its commits.
qrWithCenterAvatar); pager fills the remaining height with top-aligned pages so content no longer shifts position when switching tabs.iOS counterparts: the pay/QR modal styling introduced alongside barrydeen/wisp-ios#360, and the existing iOS profile editor / profile menu.
Test plan
Validated on a Galaxy A54 (SM-A546U).