feat(ui): render markdown math#878
Open
ishowman wants to merge 2 commits into
Open
Conversation
|
Would it be possible to also support |
Author
I've submitted new commit for it.Could you please verify if the result matches your expectations when you have spare time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Close #831, and extend Plannotator math rendering to support the common KaTeX/LLM-friendly delimiters
\(...\)and\[...\], in addition to the existing$...$and$$...$$forms.What changed
$...$and\(...\).$$...$$and\[...\].Scope
This stays within the UI/parser layer and does not require server API changes.
Validation
bun test packages/ui/components/InlineMarkdown.test.ts packages/ui/utils/parser.test.tsPATH=/Users/xxq/Documents/codes/plannotator/packages/ui/node_modules/.bin:$PATH bun run typecheckgit diff --checkNotes
This update is aimed at markdown generated by LLMs and math rendered by KaTeX-style delimiters.