chore(ci): replace Busy Engineer's Workshop validation with in-repo install-and-import smoke test#804
Open
lucasmcdonald3 wants to merge 5 commits into
Open
chore(ci): replace Busy Engineer's Workshop validation with in-repo install-and-import smoke test#804lucasmcdonald3 wants to merge 5 commits into
lucasmcdonald3 wants to merge 5 commits into
Conversation
…nstall-and-import smoke test The Busy Engineer's Document Bucket workshop (https://github.com/aws-samples/busy-engineers-document-bucket and its host https://document-bucket.awssecworkshops.com) is being torn down (ticket P417981931). The release-validate CodeBuild step depended on cloning that repo and running its mocked pytest suite to confirm the freshly-published aws-encryption-sdk wheel still works for a downstream consumer. The workshop tests are fully mocked (KMS, S3, DDB, and decrypt are all mock.Mock/MagicMock), so the only real signal the step produced was: 1. the published wheel installs on a supported Python, and 2. `aws_encryption_sdk` imports, including legacy public symbols like `StrictAwsKmsMasterKeyProvider`. This change reproduces exactly that signal without the workshop dependency: pip install the released $VERSION, then import the package and the legacy symbol. Retry behavior is preserved.
Node 16 is EOL. The latest @aws-crypto/integration-node pulls @smithy/core which requires crypto.getRandomValues() (Node 19+). Bump to Node 22 LTS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Busy Engineer's Workshop is being torn down. The old validate step ran
test_api.py, which is fully mocked — the only real test against the published wheel was a smoke test that it installs and imports. This PR keeps that smoke test without the workshop.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.