ci: add Java 17/21, replace busy-engineers-document-bucket validate, upgrade jacoco#2183
Merged
Merged
Conversation
added 5 commits
May 13, 2026 22:15
Node 16 is EOL. The latest @aws-crypto/integration-node pulls @smithy/core which requires crypto.getRandomValues() (Node 19+). Bump to Node 22 LTS.
lucasmcdonald3
force-pushed
the
lucasmcdonald3/add-java-17-21-ci
branch
from
f55f014 to
0167e3a
Compare
The old validateCI job cloned aws-samples/busy-engineers-document-bucket (a deprecated workshop) and ran mvn verify on it. Its tests only exercised data model POJOs and never called AwsCrypto encrypt/decrypt. The only real value was confirming the published artifact is resolvable and compilable by a downstream consumer. This replaces it with a minimal in-repo consumer that pulls the artifact from CodeArtifact, compiles against the ESDK public API, and instantiates AwsCrypto — validating the same thing without depending on an external repo. See: https://github.com/aws-samples/busy-engineers-document-bucket/blob/master/exercises/java/encryption-context-complete/src/test
lucasmcdonald3
changed the title
sharmabikram
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
validateCIdependency onbusy-engineers-document-bucket(deprecated workshop) with an in-repo consumer smoke testjacoco-maven-pluginfrom 0.8.8 to 0.8.12 for Java 17/21 supportSquash/merge commit message, if applicable:
ci: add Java 17/21, replace busy-engineers validate with in-repo smoke test, upgrade jacoco
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.