Skip to content

Fix AWS_ENDPOINT_URL following spec #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onno-vos-dev merged 1 commit into from
Jun 1, 2026
Merged

Fix AWS_ENDPOINT_URL following spec #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/aws_codegen/post_service.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ defmodule AWS.CodeGen.PostService do
signing_name: signing_name,
signature_version: AWS.CodeGen.Util.get_signature_version(service),
service_id: AWS.CodeGen.Util.get_service_id(service),
endpoint_url_env_var: "AWS_ENDPOINT_URL_" <> spec.module_name |> String.upcase(),
endpoint_url_env_var:
"AWS_ENDPOINT_URL_" <>
(service
|> AWS.CodeGen.Util.get_service_id()
|> String.replace(" ", "_")
|> String.upcase()),
target_prefix: target_prefix(spec.api)
}
end
Expand Down
7 changes: 6 additions & 1 deletion lib/aws_codegen/rest_service.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,12 @@ defmodule AWS.CodeGen.RestService do
signing_name: signing_name,
signature_version: AWS.CodeGen.Util.get_signature_version(service),
service_id: AWS.CodeGen.Util.get_service_id(service),
endpoint_url_env_var: "AWS_ENDPOINT_URL_" <> spec.module_name |> String.upcase(),
endpoint_url_env_var:
"AWS_ENDPOINT_URL_" <>
(service
|> AWS.CodeGen.Util.get_service_id()
|> String.replace(" ", "_")
|> String.upcase()),
## TODO: metadata["targetPrefix"],
target_prefix: nil,
shapes: Shapes.collect_shapes(language, spec.api)
Expand Down
2 changes: 1 addition & 1 deletion test/aws_codegen/rest_service_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ defmodule AWS.CodeGen.RestServiceTest do
module_name: "AWS.CloudTrailData",
protocol: "rest-json",
service_id: "CloudTrail Data",
endpoint_url_env_var: "AWS_ENDPOINT_URL_AWS.CLOUDTRAILDATA", # For Erlang this would be: AWS_ENDPOINT_URL_CLOUDTRAILDATA
endpoint_url_env_var: "AWS_ENDPOINT_URL_CLOUDTRAIL_DATA",
signature_version: "v4",
signing_name: "cloudtrail-data",
target_prefix: nil
Expand Down
Loading