Conversation
There was a problem hiding this comment.
This Config file is only used for internal Amazon packages, so we shouldn't have it here
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v2 | ||
| with: | ||
| role-to-assume: arn:aws:iam::123456789012:role/GitHubActionRole | ||
| - name: Deploy Lambda function | ||
| uses: aws-actions/amazon-lambda-deploy@v1 | ||
| with: | ||
| function-name: my-lambda-function | ||
| code-artifacts-dir: ./dist |
There was a problem hiding this comment.
Should we have a build step in the example so that a user is not required to build and commit the build artifacts for things to work?
There was a problem hiding this comment.
I was thinking about that, but realized that different runtimes have different build steps.
| code-artifacts-dir: ./dist | ||
| ``` | ||
|
|
||
| To use OIDC authentication, you must configure a trust policy in AWS IAM that allows GitHub Actions to assume an IAM role. Here's an example trust policy: |
There was a problem hiding this comment.
Is there some docs of the configure-aws-credentials that we could link to in our README when it comes to setting up credentials?
There was a problem hiding this comment.
There was a problem hiding this comment.
How about the quick start for OIDC? https://github.com/aws-actions/configure-aws-credentials/tree/main?tab=readme-ov-file#quick-start-oidc-recommended
There was a problem hiding this comment.
node_module directory should be excluded via .gitignore
There was a problem hiding this comment.
It looks like .gitignore was excluded from this change. We should be ignoring directories like node_modules and coverage.
e.g. https://github.com/aws-actions/amazon-ecs-deploy-task-definition/blob/master/.gitignore
chloe1818
force-pushed
the
initial
branch
2 times, most recently
from
3baf077 to
79929a4
Compare
chloe1818
left a comment
chloe1818
left a comment
There was a problem hiding this comment.
Updated initial files
|
Looks like these checks require the repo to be public in order to run properly. Besides this the changes look good. |
2 participants
Issue #, if available:
N/A
Description of changes:
These are the initial project files being added to the repository.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.