Skip to content

selection: install resize pointer listeners once #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avanelsas merged 3 commits into from
May 12, 2026
Merged

selection: install resize pointer listeners once #49

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95a8b45
inline-edit: replace mutable JS cell with Clojure atom
avanelsas May 12, 2026
901d346
selection: install resize pointer listeners once
avanelsas May 12, 2026
c3f2750
Revert "inline-edit: replace mutable JS cell with Clojure atom"
avanelsas May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/bareforge/render/selection.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,7 @@
(unchecked-set resize-state "element" nil)
(unchecked-set resize-state "node-id" nil)
(when-let [overlay (overlay-el)]
(.removeAttribute overlay "data-resizing"))
(.removeEventListener js/window "pointermove" on-resize-move!)
(.removeEventListener js/window "pointerup" on-resize-up!))
(.removeAttribute overlay "data-resizing")))

(defn- commit-resize!
"Build the updated document for a resize commit. Free mode writes
Expand Down Expand Up @@ -358,9 +356,7 @@
(unchecked-set resize-state "start-w" cur-w)
(unchecked-set resize-state "start-h" cur-h)
(when-let [overlay (overlay-el)]
(.setAttribute overlay "data-resizing" ""))
(.addEventListener js/window "pointermove" on-resize-move!)
(.addEventListener js/window "pointerup" on-resize-up!)))))
(.setAttribute overlay "data-resizing" ""))))))

(defn- on-handle-pointerdown! [^js e]
(let [^js target (.-target e)
Expand Down Expand Up @@ -395,18 +391,21 @@
"Mount the selection overlay pool inside `canvas-host-el`. Seeds the
pool with one primary overlay (handles attached), installs a
watcher on `state/app-state` that fires on selection / document
changes, and wires a window resize listener for layout-shift
cases. Safe to call once at app startup."
changes, wires a window resize listener for layout-shift cases, and
attaches the resize-drag pointermove / pointerup listeners *once*
here — both handlers are inert (early-exit on `resize-active?`)
until a handle pointerdown starts a drag. Safe to call once at app
startup."
[^js canvas-host-el]
(unchecked-set overlay-state "host" canvas-host-el)
(unchecked-set overlay-state "pool" #js [])
(create-overlay! true)
(schedule-refresh!)
;; Refresh on selection or document changes (an edit or a click moves
;; the rect under us) AND on canvas-view changes (zoom + pan move
;; the rendered nodes' visual rects, and overlays are read off
;; getBoundingClientRect — without this the blue border stays put
;; while the canvas slides under it).
;; the rect under us) AND on canvas-view changes (zoom + pan move
;; the rendered nodes' visual rects, and overlays are read off
;; getBoundingClientRect — without this the blue border stays put
;; while the canvas slides under it).
(add-watch state/app-state ::selection-overlay
(fn [_ _ old-state new-state]
(when (or (not= (:selection old-state) (:selection new-state))
Expand All @@ -415,4 +414,6 @@
(state/canvas-view new-state)))
(schedule-refresh!))))
(.addEventListener js/window "resize"
(fn [_] (schedule-refresh!))))
(fn [_] (schedule-refresh!)))
(.addEventListener js/window "pointermove" on-resize-move!)
(.addEventListener js/window "pointerup" on-resize-up!))
Loading