Invalid mmap(2) call with MAP_ANONYMOUS and fd 0#2
Open
Low-power wants to merge 1 commit intoashfordneil:masterfrom
Open
Invalid mmap(2) call with MAP_ANONYMOUS and fd 0#2Low-power wants to merge 1 commit intoashfordneil:masterfrom
Low-power wants to merge 1 commit intoashfordneil:masterfrom
Conversation
Low-power
changed the title
Low-power
force-pushed
the
fix-invalid-mmap
branch
from
98e5e20 to
be76b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code contains a non-portable use of mmap(2). It requests
MAP_ANONYMOUS, but the file descriptor is not-1. POSIX specified that in case ofMAP_ANONYMOUS, the file descriptor should be-1, otherwise the effect is unspecified.1 Apparently Linux simply ignores the file descriptor in this case, but other implementations such as FreeBSD kernel, may reject it with anEINVAL.2The file descriptor should be set to
-1for anonymous pages.Footnotes
mmap - The Open Group Base Specifications Issue 8 ↩
mmap(2) - FreeBSD Manual Pages ↩