[codex] surface managed utility backend errors#941
Draft
artemgetmann wants to merge 1 commit into
Draft
Conversation
- what: include bounded sanitized backend error bodies when managed utility calls fail. - why: GoPlaces provider failures must show Google PERMISSION_DENIED instead of collapsing to HTTP 502. - risk: low; only non-2xx managed utility error messages change and backend redaction remains server-owned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Fast Path
HTTP 502.pnpm vitest run src/consumer/google-places-search.test.ts src/consumer/jarvis-backend-client.test.ts;cd services/jarvis-backend && . .venv/bin/activate && pytest tests/test_app.py.403 PERMISSION_DENIEDfrom the managed backend without reading Render/backend internals.jarvis-backendGoogle Places key still fails provider-side with Google403; this PR does not rotate or reconfigure Google Cloud credentials.Why This Matters
Jarvis managed utility failed with HTTP 502.POST https://jarvis-backend-klvq.onrender.com/v1/managed/utilities/google_places.search502with sanitized body showingprovider=google_places, upstreamstatus=403, and GooglePERMISSION_DENIED.GOOGLE_PLACES_API_KEYis present, but direct provider validation of the Render-held key returns Google403.Scope Boundary
src/consumer/jarvis-backend-client.tsand its test.<available_skills>, Telegram, media, or routing-policy changes.Verification
Failing-before/provider evidence:
Observed:
{"detail":{"provider":"google_places","status":403,"payload":{"error":{"code":403,"message":"The caller does not have permission","status":"PERMISSION_DENIED"}}}} HTTP_STATUS:502Passing-after code proof:
Observed: 2 files passed, 10 tests passed.
Observed: 34 passed, 8 warnings.
AI Assistance