Added gemm matrix accumulation matrix into interface and tests#54
Merged
syurkevi merged 1 commit intoarrayfire:masterfrom Aug 29, 2025
Merged
Added gemm matrix accumulation matrix into interface and tests#54syurkevi merged 1 commit intoarrayfire:masterfrom
syurkevi merged 1 commit intoarrayfire:masterfrom
Conversation
syurkevi
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
af.gemmfunction was missing and interface to pass explicitly an accumulation matrix. Previously it required a call af.gemm so that the result was stored in the accumulator. By adding the parameteraccumstanding for the accumulation, we copy the array into the accumulation and proceed with thegemmfunction as usual.Requires PR#26 from the arrayfire-py repo