fix: distinguish SSH auth exhaustion from invalid credentials#241
Draft
tgonzalezorlandoarm wants to merge 1 commit intomainfrom
Draft
fix: distinguish SSH auth exhaustion from invalid credentials#241tgonzalezorlandoarm wants to merge 1 commit intomainfrom
tgonzalezorlandoarm wants to merge 1 commit intomainfrom
Conversation
…th checks We already classify `too many authentication failures` as a distinct SSH error, but the health report was still treating it like a generic auth failure and suggesting only `topo setup-keys`. Handle this case explicitly in the probe and health layers so the user gets a more accurate fix suggestion: - map SSH `too many authentication failures` to a dedicated probe error - surface a health fix that points users to their SSH config/key selection while still offering `topo setup-keys` as a recovery path This keeps `permission denied` and `too many authentication failures` separate, which better reflects the likely cause of the failure. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm
force-pushed
the
too-many-auth-failures
branch
from
7402d59 to
bbb39a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We already classify
too many authentication failuresas a distinct ssh error, but the health report was still treating it like a generic auth failure and suggesting onlytopo setup-keys.Changes
Handle this case explicitly in the probe and health layers so the user gets a more accurate fix suggestion:
too many authentication failuresto a dedicated probe errortopo setup-keysas a recovery pathThis keeps
permission deniedandtoo many authentication failuresseparate, which better reflects the likely cause of the failure.