Skip to content

fix(tui): show all submit keybindings in dialog prompt hint bar#287

Open
ariane-emory wants to merge 1 commit into
devfrom
fix/dialog-prompt-submit-hints
Open

fix(tui): show all submit keybindings in dialog prompt hint bar#287
ariane-emory wants to merge 1 commit into
devfrom
fix/dialog-prompt-submit-hints

Conversation

@ariane-emory

Copy link
Copy Markdown
Owner

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

fix(tui): show all submit keybindings in dialog prompt hint bar

Summary

The dialog prompt hint bar (e.g. Rename Session) only displayed the first
input.submit keybinding instead of all of them. With
input_submit: "shift+return,ctrl+return,alt+return", the hint showed only
shift+enter.

Changes

  • keymap.tsx — Added useCommandShortcuts hook that returns all
    registered bindings for a command (vs useCommandShortcut which returns
    only [0]). Also added enter: "return" to keyNameAliases so the
    display matches the user's config key names.
  • dialog-prompt.tsx — Replaced useCommandShortcut with
    useCommandShortcuts and joined all bindings with / in the hint bar
    (e.g. shift+return/ctrl+return/alt+return submit).

Test plan

  • Open a dialog prompt (e.g. Rename Session via session.rename)
  • Confirm the hint bar shows all submit keybindings, not just one
  • Confirm key names display as return (not enter)
  • Confirm each binding still submits the dialog when pressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant