Fix unsigned params for babeltrace_thapi (display_name_max_size, offset)#500
Merged
Conversation
TApplencourt
force-pushed
the
fix-unsigned-params
branch
from
3b307ac to
1b65001
Compare
The previous workaround wrapped values as "+#{int}" strings, intending to
mark them as babeltrace2 unsigned. But the Ruby BT2.from_value routes
String to BTValueString, so the C side called bt_value_integer_unsigned_get
on a string handle and got garbage. Pass bare Integers instead — from_value
already routes >2**63-1 to BTValueIntegerUnsigned automatically.
Adds two regression tests in integration_tests/general.bats:
- max-name-size: truncation marker appears at small size, absent at -1
- timeline_output-offset_deterministic: two replays must produce identical files
Also adds run -0 to stderr_output and read_stdin which were using bare run
but assumed exit 0.
Will fix #498
TApplencourt
force-pushed
the
fix-unsigned-params
branch
from
1b65001 to
0ce3525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous workaround wrapped values as "+#{int}" strings, intending to mark them as babeltrace2 unsigned. But the Ruby BT2.from_value routes String to BTValueString, so the C side called bt_value_integer_unsigned_get on a string handle and got garbage. Pass bare Integers instead — from_value already routes >2**63-1 to BTValueIntegerUnsigned automatically.
Adds two regression tests in integration_tests/general.bats:
Also adds run -0 to stderr_output and read_stdin which were using bare run but assumed exit 0.
Will fix #498