Fix in_pktinfo, disable Vsock, and fix SHUT_* constants on FreeBSD#3595
Draft
rafaelcepeda wants to merge 16 commits into
Draft
Fix in_pktinfo, disable Vsock, and fix SHUT_* constants on FreeBSD#3595rafaelcepeda wants to merge 16 commits into
rafaelcepeda wants to merge 16 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the final FreeBSD build errors to achieve a clean NIOPosix compilation on FreeBSD.
Motivation:
After the previous PR added import
CNIOFreeBSDand per-socketSO_NOSIGPIPEhandling, 6 errors remained: (1) FreeBSD doesn't have thein_pktinfo struct(it usesIP_RECVDSTADDRinstead), (2) FreeBSD doesn't supportAF_VSOCK, and (3)SHUT_RD/SHUT_WR/SHUT_RDWRare imported as a shutdown_how enum requiring .rawValue access.Modifications:
ControlMessage.swift— Added!os(FreeBSD)to thein_pktinfoexclusion guard (matching OpenBSD pattern). -SocketChannel.swift— Addedos(FreeBSD)to all threeVsockexclusion guards.System.swift— ChangedSHUT_*constants to useCNIOFreeBSD.SHUT_*.rawValue.Result:
NIOPosix compiles with zero errors on FreeBSD 15. Error count drops from 6 to 0. Combined with the previous PRs, this completes the FreeBSD port of NIOPosix (from 101 errors to a clean build).