Skip to content

chore(deps): upgrade frontend to Angular 17#4403

Open
aglinxinyuan wants to merge 2 commits intomainfrom
xinyuan-angular-17
Open

chore(deps): upgrade frontend to Angular 17#4403
aglinxinyuan wants to merge 2 commits intomainfrom
xinyuan-angular-17

Conversation

@aglinxinyuan
Copy link
Copy Markdown
Contributor

@aglinxinyuan aglinxinyuan commented Apr 17, 2026

Summary

This PR upgrades the frontend/ app from Angular 16 to Angular 17 and updates the related toolchain so the app still builds and tests successfully.

What Changed

  • Upgraded Angular core packages to 17.3.x
  • Upgraded Angular CLI/devkit/compiler tooling to 17.3.x
  • Upgraded Angular-adjacent packages that needed to move with the framework:
    • @angular/cdk
    • ng-zorro-antd
    • ngx-markdown
    • zone.js
    • typescript
    • @angular-builders/custom-webpack
    • Angular ESLint packages
  • Added explicit devkit/schematics/webpack dependencies needed by the current workspace setup
  • Regenerated frontend/yarn.lock

Code Adjustments

  • Updated markdown rendering to handle the newer ngx-markdown parse API, which can return asynchronously
  • Fixed a duplicate computed-property assignment that TypeScript 5.4 rejects
  • Removed an invalid CSS declaration that Angular 17’s stylesheet pipeline surfaced
  • Cleaned a few template/CSS warnings exposed by the newer compiler/toolchain:
    • unnecessary optional chaining in the dataset detail template
    • start alignment values changed to flex-start where appropriate

Any related issues, documentation, discussions?

Closes #4402

How was this PR tested?

  • yarn.cmd install
  • yarn.cmd build
  • yarn.cmd test --watch=false

Build and tests both pass.

Tested the frontend manually, including dataset uploading, workflow editor, and UDF editor.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Codex

@aglinxinyuan aglinxinyuan self-assigned this Apr 17, 2026
Copilot AI review requested due to automatic review settings April 17, 2026 05:28
@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI labels Apr 17, 2026
@aglinxinyuan aglinxinyuan requested review from Xiao-zhen-Liu and bobbai00 and removed request for Xiao-zhen-Liu April 17, 2026 05:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the frontend/ application from Angular 16 to Angular 17, updating the surrounding toolchain and making small code/CSS adjustments to keep builds and tests passing.

Changes:

  • Bumped Angular framework packages and related frontend dependencies/tooling (CLI, devkit, TypeScript, zone.js, ng-zorro, ngx-markdown, etc.).
  • Updated markdown rendering to support async ngx-markdown parsing.
  • Cleaned up template/CSS issues surfaced by the Angular 17 toolchain (invalid CSS, alignment values, optional chaining).

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
frontend/src/app/workspace/service/joint-ui/joint-ui.service.ts Fixes duplicate computed-property assignment by merging attrs into a single object.
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.scss Replaces start alignment values with flex-start to satisfy updated CSS processing.
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html Removes unnecessary optional chaining after *ngIf="selectedVersion" narrowing.
frontend/src/app/dashboard/component/user/user-computing-unit/user-computing-unit.component.scss Replaces align-items: start with flex-start.
frontend/src/app/dashboard/component/user/markdown-description/markdown-description.component.ts Adapts markdown parsing/rendering flow to handle async parse results.
frontend/src/app/common/formly/collab-wrapper/collab-wrapper/collab-wrapper.component.css Removes an invalid CSS declaration.
frontend/package.json Updates Angular to 17.3.x and refreshes related dependency versions/tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/package.json Outdated
@aglinxinyuan aglinxinyuan requested review from Xiao-zhen-Liu and kunwp1 and removed request for Xiao-zhen-Liu April 17, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 17

2 participants