chore(deps): upgrade frontend to Angular 17#4403
Open
aglinxinyuan wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the frontend/ application from Angular 16 to Angular 17, updating the surrounding toolchain and making small code/CSS adjustments to keep builds and tests passing.
Changes:
- Bumped Angular framework packages and related frontend dependencies/tooling (CLI, devkit, TypeScript, zone.js, ng-zorro, ngx-markdown, etc.).
- Updated markdown rendering to support async
ngx-markdownparsing. - Cleaned up template/CSS issues surfaced by the Angular 17 toolchain (invalid CSS, alignment values, optional chaining).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/app/workspace/service/joint-ui/joint-ui.service.ts | Fixes duplicate computed-property assignment by merging attrs into a single object. |
| frontend/src/app/workspace/component/power-button/computing-unit-selection.component.scss | Replaces start alignment values with flex-start to satisfy updated CSS processing. |
| frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html | Removes unnecessary optional chaining after *ngIf="selectedVersion" narrowing. |
| frontend/src/app/dashboard/component/user/user-computing-unit/user-computing-unit.component.scss | Replaces align-items: start with flex-start. |
| frontend/src/app/dashboard/component/user/markdown-description/markdown-description.component.ts | Adapts markdown parsing/rendering flow to handle async parse results. |
| frontend/src/app/common/formly/collab-wrapper/collab-wrapper/collab-wrapper.component.css | Removes an invalid CSS declaration. |
| frontend/package.json | Updates Angular to 17.3.x and refreshes related dependency versions/tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the
frontend/app from Angular 16 to Angular 17 and updates the related toolchain so the app still builds and tests successfully.What Changed
17.3.x17.3.x@angular/cdkng-zorro-antdngx-markdownzone.jstypescript@angular-builders/custom-webpackfrontend/yarn.lockCode Adjustments
ngx-markdownparse API, which can return asynchronouslystartalignment values changed toflex-startwhere appropriateAny related issues, documentation, discussions?
Closes #4402
How was this PR tested?
yarn.cmd installyarn.cmd buildyarn.cmd test --watch=falseBuild and tests both pass.
Tested the frontend manually, including dataset uploading, workflow editor, and UDF editor.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex