WW-3647 Change autowire alwaysRespect default to true#1571
Merged
lukaszlenart merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
Change the default value of struts.objectFactory.spring.autoWire.alwaysRespect from false to true to fix the Spring constructor autowiring issue. When a Spring String bean exists (e.g., JNDI lookup with default-value), Spring's AUTOWIRE_CONSTRUCTOR strategy incorrectly injects that value into ALL String parameters of ServletActionRedirectResult constructors, causing malformed redirect URLs. Setting alwaysRespect to true by default ensures the configured autowire strategy (AUTOWIRE_BY_NAME) is consistently used, preventing unintended bean injection. Users who rely on the legacy constructor autowiring behavior can restore it by setting: <constant name="struts.objectFactory.spring.autoWire.alwaysRespect" value="false" /> Fixes https://issues.apache.org/jira/browse/WW-3647 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
|
jogep
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
struts.objectFactory.spring.autoWire.alwaysRespectfromfalsetotrueStrutsConstants.javato reflect new default and reference WW-3647SpringObjectFactory.javaProblem
When a Spring String bean exists (e.g., JNDI lookup with default-value), Spring's
AUTOWIRE_CONSTRUCTORstrategy incorrectly injects that value into ALL String parameters ofServletActionRedirectResultconstructors, causing malformed redirect URLs like:Solution
Change the default to
trueso Spring respects the configured autowire strategy (AUTOWIRE_BY_NAMEby default) instead of using the legacy mixed injection approach that always tries constructor injection first.Migration Notes
Users who rely on the legacy constructor autowiring behavior can restore it by setting:
Test plan
SpringObjectFactoryTest- 11 tests)Fixes WW-3647
🤖 Generated with Claude Code