Feat : Use custom host for S3 (not only AWS)#40
Open
KontainPluton wants to merge 5 commits intoapache:mainfrom
Open
Feat : Use custom host for S3 (not only AWS)#40KontainPluton wants to merge 5 commits intoapache:mainfrom
KontainPluton wants to merge 5 commits intoapache:mainfrom
Conversation
added 2 commits
February 10, 2026 12:29
…a stored on custom S3 storage (not only AWS)
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
KontainPluton
force-pushed
the
feat/CustomHostS3
branch
from
7714952 to
28b3170
Compare
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java
Outdated
Show resolved
Hide resolved
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java
Outdated
Show resolved
Hide resolved
desruisseaux
reviewed
Mar 8, 2026
| * - Self-Hosted path : s3://accessKey@host:port/bucket/key | ||
| * - AWS path : s3://accessKey@bucket/key | ||
| */ | ||
| boolean selfHosted = fs.host != null && fs.port >= 0; |
Contributor
There was a problem hiding this comment.
With this condition, either the URI has a host and a port, or either it has none of them. If only one of them is specified, this is silently ignored. But is it really illegal to specify only a host with a default port number? The implementation of toString() just below this method suggests that it is legal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Self-hosted S3