SAMOA-75 : Integration of the new features in instances#72
Open
mehdidb wants to merge 1 commit into
Open
Conversation
|
@mehdidb wasn't this in a different PR? If yes, do you want to remove it? |
Contributor
Author
|
@nicolas-kourtellis it was in a different pull request but i have closed it since it has many changes and i have only kept relevant changes in the code. |
csterling
approved these changes
Nov 18, 2019
csterling
left a comment
csterling
left a comment
Contributor
There was a problem hiding this comment.
+1, mostly cosmetic but includes implementation of some helpful methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.