Skip to content

Code cleanups and warnings#46

Open
smarthi wants to merge 1 commit into
apache:masterfrom
smarthi:master
Open

Code cleanups and warnings#46
smarthi wants to merge 1 commit into
apache:masterfrom
smarthi:master

Conversation

@smarthi

@smarthi smarthi commented Dec 23, 2015

Copy link
Copy Markdown
Member

No description provided.

@gdfm

gdfm commented Jan 31, 2016

Copy link
Copy Markdown
Contributor

Thanks for the nice cleanup, +1.
Will wait for a second review before committing.

@abifet

abifet commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

I like very much the cleanup. However, I see some changes in the code of RandomRBFGeneratorEvents, Can you explain why these changes are needed? Thanks!

@asfgit asfgit force-pushed the master branch 2 times, most recently from f9db1f2 to 1bd1012 Compare March 16, 2016 06:12
csterling
csterling approved these changes Nov 18, 2019
View reviewed changes

@csterling csterling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, makes the code more concise in several places.

@csterling

csterling commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

I like very much the cleanup. However, I see some changes in the code of RandomRBFGeneratorEvents, Can you explain why these changes are needed? Thanks!

@abifet It seems to me that the code changes you mentioned are the removal of dead code branches (i.e. the conditions are impossible to satisfy).

@abifet

abifet commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

@abifet It seems to me that the code changes you mentioned are the removal of dead code branches (i.e. the conditions are impossible to satisfy).

@csterling Thanks! +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@csterling csterling csterling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smarthi @gdfm @abifet @csterling