Skip to content

refactor: Optimize SnapshotUtil ancestor methods with early return #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
WZhuo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Optimize SnapshotUtil ancestor methods with early return #560

WZhuo wants to merge 1 commit into from
+171 −68

Conversation

@WZhuo
Copy link
Contributor

@WZhuo WZhuo commented Feb 11, 2026

  • Optimize IsAncestorOf to return early instead of collecting all ancestors
  • Optimize IsParentAncestorOf to return early when matching parent is found
  • Add TableMetadata overloads for AncestorsOf, AncestorsBetween, OldestAncestorOf
  • Add IsParentAncestorOf overload with custom lookup function

@WZhuo
refactor: Optimize SnapshotUtil ancestor methods with early return
0d1d9b8 
- Optimize IsAncestorOf to return early instead of collecting all ancestors
- Optimize IsParentAncestorOf to return early when matching parent is found
- Add TableMetadata overloads for AncestorsOf, AncestorsBetween, OldestAncestorOf
- Add IsParentAncestorOf overload with custom lookup function
zhjwpku
zhjwpku approved these changes Feb 11, 2026
View reviewed changes
Copy link
Collaborator

@zhjwpku zhjwpku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An early return should improve performance when there is a large snapshot history, so +1 from me. Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zhjwpku zhjwpku zhjwpku approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WZhuo @zhjwpku