[VL][UT] Enable two tests previously failing due to Velox Expand operator bug#11947
Merged
jinchengchenghh merged 1 commit intoapache:mainfrom Apr 16, 2026
Merged
[VL][UT] Enable two tests previously failing due to Velox Expand operator bug#11947jinchengchenghh merged 1 commit intoapache:mainfrom
jinchengchenghh merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
@jinchengchenghh, could you take a look? |
philo-he
changed the title
jinchengchenghh
approved these changes
Apr 16, 2026
Contributor
jinchengchenghh
left a comment
jinchengchenghh
left a comment
There was a problem hiding this comment.
Thanks for figuring out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Enable these two tests in
GlutenDeltaBasedUpdateAsDeleteAndInsertTableSuite. It covers Spark's delta-based row update, which uses a row operation flag to mark deletes and inserts. An Expand operator duplicates each row into two — one for delete and one for insert. When updating a table with the WriteDelta operator, delete records are filtered out based on the row operation flag.For the delete flag marked row, NULL literal will be used to replace the deprecated data, passing to Expand operators. Previously, the operator incorrectly handles literals of complex types, finally producing NULLs instead of the expected values. This bug was fixed by Velox PR some months ago: facebookincubator/velox#15684.
How was this patch tested?
Local test passed.
Was this patch authored or co-authored using generative AI tooling?
No.